Hop nodes for k8s #13904

fosterseth · 2023-04-25T18:10:54Z

SUMMARY

Allow users to setup hop nodes for k8s deployments

revert using devel receptor-collection before merging

ISSUE TYPE

New or Enhanced Feature

COMPONENT NAME

API

AWX VERSION

awx: 22.0.1

awx/api/serializers.py

awx/api/views/__init__.py

awx/api/views/root.py

awx/main/migrations/0186_hop_nodes.py

AlanCoding · 2023-07-12T17:52:42Z

in operator check:

Traceback (most recent call last):
  File \"/var/lib/awx/venv/awx/lib64/python3.9/site-packages/awx/main/tasks/jobs.py\", line 597, in run
    res = receptor_job.run()
  File \"/var/lib/awx/venv/awx/lib64/python3.9/site-packages/awx/main/tasks/receptor.py\", line 318, in run
    res = self._run_internal(receptor_ctl)
  File \"/var/lib/awx/venv/awx/lib64/python3.9/site-packages/awx/main/tasks/receptor.py\", line 393, in _run_internal
    res = processor_future.result()
  File \"/usr/lib64/python3.9/concurrent/futures/_base.py\", line 446, in result
    return self.__get_result()
  File \"/usr/lib64/python3.9/concurrent/futures/_base.py\", line 391, in __get_result
    raise self._exception
  File \"/usr/lib64/python3.9/concurrent/futures/thread.py\", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File \"/var/lib/awx/venv/awx/lib64/python3.9/site-packages/awx/main/utils/common.py\", line 1189, in wrapper_cleanup_new_process
    return func(*args, **kwargs)
  File \"/var/lib/awx/venv/awx/lib64/python3.9/site-packages/awx/main/tasks/receptor.py\", line 461, in processor
    return ansible_runner.interface.run(
  File \"/var/lib/awx/venv/awx/lib64/python3.9/site-packages/ansible_runner/interface.py\", line 210, in run
    r = init_runner(**kwargs)
  File \"/var/lib/awx/venv/awx/lib64/python3.9/site-packages/ansible_runner/interface.py\", line 107, in init_runner
    stream_processor = Processor(event_handler=event_callback_handler,
  File \"/var/lib/awx/venv/awx/lib64/python3.9/site-packages/ansible_runner/streaming.py\", line 270, in __init__
    self.artifact_dir = os.path.join(project_artifacts, ident)
  File \"/usr/lib64/python3.9/posixpath.py\", line 90, in join
    genericpath._check_arg_types('join', a, *p)
  File \"/usr/lib64/python3.9/genericpath.py\", line 152, in _check_arg_types
    raise TypeError(f'{funcname}() argument must be str, bytes, or '
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'int'

This is fixed with ansible/ansible-runner#1268

awx/main/models/ha.py

This reverts commit cf5ccf5.

Dynamically flipping from Established to Disconnected is not the intended usage of InstanceLink State. - Link state starts in Adding and becomes Established once any control node first sees the link is in the status KnownConnectionCosts

API changes - cannot change peers or enable peers_from_control_nodes on VM deployments - allow setting ip_address - use ip_address over hostname in the generated group_vars/all.yml - Drop api/v2/peers endpoint DB changes - add ip_address unique constraint, but ignore "" entries Other changes - provision_instance should take listener_port option Tests - test that new controls doesn't disturb other peers relationships - test ip_address over hostname

Get rid of PeersSerializer and just use SlugRelatedField, which should be more a straightforward approach. Other changes: - cleanup code related to the already-removed api/v2/peers endpoint - add "hybrid" node type into more instance_peers test cases

Add a check_peers_changed() utility method to determine if peers in attrs matches the current instance peers. Other changes: - Set ip_address default to "", and do not allow null.

Setting a different value for ip_address and hostname does not work with the current way we create receptor certs.

Make test case cleaner by using itertools product instead of the triple nested loop Replace triple single quotes with triple double quotes

Might help to install receptor last, that way when nodes are first connected to the mesh they already have podman installed and can potentially run jobs. Otherwise it might be possible for controller to launch jobs against nodes that aren't fully set up.

receptor_host_identifier can be left out of group_vars and will default to the 'ansible_host' variable

)

janorn · 2023-08-24T10:11:47Z

awx/api/templates/instance_install_bundle/install_receptor.yml

@@ -7,14 +7,11 @@
      user:
        name: "{{ receptor_user }}"
        shell: /bin/bash
-    - name: Enable Copr repo for Receptor
-      command: dnf copr enable ansible-awx/receptor -y


Shouldn't this be removed from previous installed receptors?

sorry, can you clarify the question? The next receptor-collection version will install receptor via these releases by default https://github.com/ansible/receptor/releases

thus the Copr repo is no longer needed going forward

I'm thinking of upgrades of previous installs.

CFSNM · 2023-08-28T13:44:05Z

awx/api/templates/instance_install_bundle/requirements.yml

-    version: 1.1.0
+  - name: https://github.com/ansible/receptor-collection.git
+    type: git
+    version: main


do we need to point this to 2.0.0 version?

AlanCoding · 2023-08-28T15:01:27Z

tools/docker-compose/bootstrap_development.sh

@@ -40,7 +40,7 @@ echo "Admin password: ${DJANGO_SUPERUSER_PASSWORD}"
 awx-manage create_preload_data
 awx-manage register_default_execution_environments

-awx-manage provision_instance --hostname="$(hostname)" --node_type="$MAIN_NODE_TYPE"
+awx-manage provision_instance --hostname="$(hostname)" --node_type="$MAIN_NODE_TYPE" --listener_port=2222


This concerns me a little bit about the expected practice. Does this need to be provided for VM installs in general? I don't get why we didn't need this before, but would now.

So it seems that this is not required, and as such, it would make the most sense to not set it here, because the VM install scenario that this corresponds to should not ordinarily be setting the listener port.

AlanCoding · 2023-08-28T19:04:22Z

Filed a followup issue #14387

…tion (#14247)

github-actions bot added the component:api label Apr 25, 2023

github-actions bot added the component:ui label May 3, 2023

fosterseth force-pushed the feature_hop-node branch from d2662b9 to 056326e Compare May 10, 2023 17:00

fosterseth force-pushed the feature_hop-node branch 2 times, most recently from 687df1f to 91efa83 Compare May 17, 2023 19:23

relrod requested changes May 26, 2023

View reviewed changes

awx/api/serializers.py Outdated Show resolved Hide resolved

fosterseth force-pushed the feature_hop-node branch from 89be8dc to c32a37b Compare June 5, 2023 20:42

fosterseth force-pushed the feature_hop-node branch from 2e1146e to c451a63 Compare June 14, 2023 15:15

TheRealHaoLiu requested a review from relrod June 14, 2023 19:41

thedoubl3j mentioned this pull request Jun 15, 2023

[hop node] update peer validation logic #14132

Merged

fosterseth force-pushed the feature_hop-node branch from b37ac4e to 72a1cb4 Compare June 15, 2023 18:48

djyasin force-pushed the feature_hop-node branch from 72a1cb4 to 05b2b5d Compare June 15, 2023 19:23

fosterseth force-pushed the feature_hop-node branch from 05b2b5d to f6f7ba5 Compare June 20, 2023 15:45

shanemcd mentioned this pull request Jun 27, 2023

Improvements to deployments of remote instances via receptor hop when deployed with AWX operator #14171

Closed

9 tasks

fosterseth force-pushed the feature_hop-node branch from 24f2122 to f75b9ba Compare June 28, 2023 00:51

github-actions bot added the component:awx_collection issues related to the collection for controlling AWX label Jun 30, 2023

AlanCoding reviewed Jul 6, 2023

View reviewed changes

awx/api/views/__init__.py Outdated Show resolved Hide resolved

AlanCoding reviewed Jul 6, 2023

View reviewed changes

awx/api/views/root.py Outdated Show resolved Hide resolved

AlanCoding reviewed Jul 6, 2023

View reviewed changes

awx/main/migrations/0186_hop_nodes.py Outdated Show resolved Hide resolved

fosterseth changed the title ~~[WIP] Hop nodes for k8s~~ Hop nodes for k8s Jul 12, 2023

fosterseth commented Jul 13, 2023

View reviewed changes

awx/main/models/ha.py Outdated Show resolved Hide resolved

fosterseth force-pushed the feature_hop-node branch from dbeacf9 to c51e8f0 Compare July 13, 2023 18:18

github-actions bot added the component:docs label Jul 17, 2023

kurokobo mentioned this pull request Jul 19, 2023

Running install_receptor.yml fails when adding execution node(Rocky Linux 9.0). #13287

Open

9 tasks

fosterseth requested a review from jbradberry July 26, 2023 17:01

fosterseth force-pushed the feature_hop-node branch 3 times, most recently from 6b37dd6 to 00c6975 Compare July 27, 2023 22:30

fosterseth requested a review from john-westcott-iv July 31, 2023 15:33

fosterseth and others added 16 commits August 23, 2023 22:05

Revert "Remove duplicate install bundle on InstanceDetail"

b30c2bd

This reverts commit cf5ccf5.

Remove duplicate install bundle on InstanceDetail

856b12d

Remove Disconnected link state

694bb99

Dynamically flipping from Established to Disconnected is not the intended usage of InstanceLink State. - Link state starts in Adding and becomes Established once any control node first sees the link is in the status KnownConnectionCosts

Do not install ansible-runner or podman on hop nodes

2eecef4

Fix detecting if peers changed in serializer

0e8fab8

Add a check_peers_changed() utility method to determine if peers in attrs matches the current instance peers. Other changes: - Set ip_address default to "", and do not allow null.

Ensure ip_address is empty string

52ed376

Change username to <username> in inventory

b1125f1

Make ip_address read only

99a3348

Setting a different value for ip_address and hostname does not work with the current way we create receptor certs.

Use itertools product instead of nested loop

24c1f2c

Make test case cleaner by using itertools product instead of the triple nested loop Replace triple single quotes with triple double quotes

Setup receptor after podman

92620d1

Might help to install receptor last, that way when nodes are first connected to the mesh they already have podman installed and can potentially run jobs. Otherwise it might be possible for controller to launch jobs against nodes that aren't fully set up.

No longer assert on receptor_host_identifier

bd759fe

receptor_host_identifier can be left out of group_vars and will default to the 'ansible_host' variable

Removed unused variable in test_instance_peers

bc538c2

Apply JS formatting from npm prettier

cb0f4bb

Add toast and delete modal messaging when removing/adding peers. (#14373

8a4678c

)

fosterseth force-pushed the feature_hop-node branch from 0746984 to 8a4678c Compare August 24, 2023 02:05

janorn reviewed Aug 24, 2023

View reviewed changes

Use receptor-collection devel

d9d6f82

CFSNM approved these changes Aug 28, 2023

View reviewed changes

djyasin approved these changes Aug 28, 2023

View reviewed changes

AlanCoding reviewed Aug 28, 2023

View reviewed changes

AlanCoding approved these changes Aug 28, 2023

View reviewed changes

fosterseth and others added 2 commits August 28, 2023 15:09

Use receptor collection 2.0.0

123f590

docs: update execution_nodes.md to follow changes for receptor_collec…

7501542

…tion (#14247)

relrod approved these changes Aug 29, 2023

View reviewed changes

akus062381 approved these changes Aug 29, 2023

View reviewed changes

fosterseth merged commit c9190eb into devel Aug 29, 2023
15 of 16 checks passed

fosterseth deleted the feature_hop-node branch August 29, 2023 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hop nodes for k8s #13904

Hop nodes for k8s #13904

fosterseth commented Apr 25, 2023 •

edited

Loading

AlanCoding commented Jul 12, 2023

janorn Aug 24, 2023

fosterseth Aug 24, 2023 •

edited

Loading

janorn Aug 24, 2023

CFSNM Aug 28, 2023

AlanCoding Aug 28, 2023

AlanCoding Aug 28, 2023

AlanCoding commented Aug 28, 2023

Hop nodes for k8s #13904

Hop nodes for k8s #13904

Conversation

fosterseth commented Apr 25, 2023 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

AWX VERSION

AlanCoding commented Jul 12, 2023

janorn Aug 24, 2023

Choose a reason for hiding this comment

fosterseth Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

janorn Aug 24, 2023

Choose a reason for hiding this comment

CFSNM Aug 28, 2023

Choose a reason for hiding this comment

AlanCoding Aug 28, 2023

Choose a reason for hiding this comment

AlanCoding Aug 28, 2023

Choose a reason for hiding this comment

AlanCoding commented Aug 28, 2023

fosterseth commented Apr 25, 2023 •

edited

Loading

fosterseth Aug 24, 2023 •

edited

Loading